Modal prompts - Revision history

Jochen at 13:52, 16 February 2012

2012-02-16T13:52:44Z

← Older revision		Revision as of 13:52, 16 February 2012
Line 14:		Line 14:
	WebKit and Firefox don't suppress events while a modal dialog is running: https://bugs.webkit.org/show_bug.cgi?id=78240 and https://bugzilla.mozilla.org/show_bug.cgi?id=360872		WebKit and Firefox don't suppress events while a modal dialog is running: https://bugs.webkit.org/show_bug.cgi?id=78240 and https://bugzilla.mozilla.org/show_bug.cgi?id=360872

	Firefox displays modal prompts as tab-modal. However, it's possible to execute JavaScript in a tab that should be blocked by a modal prompt: https://bugzilla.mozilla.org/show_bug.cgi?id=727397 and the prompts from separate tabs can block each other: https://bugzilla.mozilla.org/show_bug.cgi?id=~~727802~~		Firefox displays modal prompts as tab-modal. However, it's possible to execute JavaScript in a tab that should be blocked by a modal prompt: https://bugzilla.mozilla.org/show_bug.cgi?id=727397 and the prompts from separate tabs can block each other: https://bugzilla.mozilla.org/show_bug.cgi?id=727801

	==Proposal==		==Proposal==
Line 52:		Line 52:

	I would like to propose deprecating and eventually removing <code>window.showModalDialog</code> from the platform. Web sites can already now use e.g. <code>window.open</code> instead. However, I'm not quite sure how this could be achieved.		I would like to propose deprecating and eventually removing <code>window.showModalDialog</code> from the platform. Web sites can already now use e.g. <code>window.open</code> instead. However, I'm not quite sure how this could be achieved.


	==Examples==		==Examples==

Jochen at 13:17, 16 February 2012

2012-02-16T13:17:43Z

← Older revision		Revision as of 13:17, 16 February 2012
Line 14:		Line 14:
	WebKit and Firefox don't suppress events while a modal dialog is running: https://bugs.webkit.org/show_bug.cgi?id=78240 and https://bugzilla.mozilla.org/show_bug.cgi?id=360872		WebKit and Firefox don't suppress events while a modal dialog is running: https://bugs.webkit.org/show_bug.cgi?id=78240 and https://bugzilla.mozilla.org/show_bug.cgi?id=360872

	Firefox displays modal prompts as tab-modal. However, it's possible to execute JavaScript in a tab that should be blocked by a modal prompt: https://bugzilla.mozilla.org/show_bug.cgi?id=727397 and the prompts ~~do not terminate necessarily in the correct order~~: https://bugzilla.mozilla.org/show_bug.cgi?id=~~727399~~		Firefox displays modal prompts as tab-modal. However, it's possible to execute JavaScript in a tab that should be blocked by a modal prompt: https://bugzilla.mozilla.org/show_bug.cgi?id=727397 and the prompts from separate tabs can block each other: https://bugzilla.mozilla.org/show_bug.cgi?id=727802

	==Proposal==		==Proposal==

Jochen at 13:09, 16 February 2012

2012-02-16T13:09:14Z

← Older revision		Revision as of 13:09, 16 February 2012
Line 64:		Line 64:
	* What would a reasonable plan to deprecate <code>showModalDialog</code> look like?		* What would a reasonable plan to deprecate <code>showModalDialog</code> look like?
	* Does it make sense to add a callback to <code>alert</code> at all?		* Does it make sense to add a callback to <code>alert</code> at all?
			* Should we rather invest in <code><dialog></code> and then try to deprecate all of the modal prompts and dialogs?


	[[Category:Proposals]]		[[Category:Proposals]]

Jochen at 22:49, 15 February 2012

2012-02-15T22:49:44Z

← Older revision		Revision as of 22:49, 15 February 2012
Line 62:		Line 62:
	==Issues==		==Issues==

	What would a reasonable plan to deprecate <code>showModalDialog</code> look like?		* What would a reasonable plan to deprecate <code>showModalDialog</code> look like?
			* Does it make sense to add a callback to <code>alert</code> at all?


	[[Category:Proposals]]		[[Category:Proposals]]

Jochen: added "Issues with current implementations"

2012-02-15T09:57:26Z

added "Issues with current implementations"

← Older revision		Revision as of 09:57, 15 February 2012
Line 8:		Line 8:

	Furthermore, implementing <code>showModalDialog</code> might require running a nested message loop which caused several security issues in the past.		Furthermore, implementing <code>showModalDialog</code> might require running a nested message loop which caused several security issues in the past.

			===Issues with current implementations===
			Chromium for example doesn't display a window created by <code>showModalDialog</code> in a modal way: http://crbug.com/16045

			WebKit and Firefox don't suppress events while a modal dialog is running: https://bugs.webkit.org/show_bug.cgi?id=78240 and https://bugzilla.mozilla.org/show_bug.cgi?id=360872

			Firefox displays modal prompts as tab-modal. However, it's possible to execute JavaScript in a tab that should be blocked by a modal prompt: https://bugzilla.mozilla.org/show_bug.cgi?id=727397 and the prompts do not terminate necessarily in the correct order: https://bugzilla.mozilla.org/show_bug.cgi?id=727399

	==Proposal==		==Proposal==

Jochen: add webidl and reword showModalDialog section

2012-02-14T19:34:54Z

add webidl and reword showModalDialog section

← Older revision		Revision as of 19:34, 14 February 2012
Line 20:		Line 20:

	When these functions are invoked with a callback parameter, they return immediately (instead of blocking). The callback is invoked as soon as the modal dialog closes. For <code>confirm</code> and <code>prompt</code>, the callback takes one parameter which is set to the value to modal version would have returned.		When these functions are invoked with a callback parameter, they return immediately (instead of blocking). The callback is invoked as soon as the modal dialog closes. For <code>confirm</code> and <code>prompt</code>, the callback takes one parameter which is set to the value to modal version would have returned.

			====WebIDL====

			Current interface

			<pre>
			void alert(DOMString message);
			boolean confirm(DOMString message);
			DOMString? prompt(DOMString message, optional DOMString default);
			</pre>

			Proposed interface

			<pre>
			void alert(DOMString message, optional VoidCallback complete);
			boolean confirm(DOMString message, BooleanCallback complete);
			DOMString? prompt(DOMString message, optional BooleanCallback complete);
			DOMString? prompt(DOMString message, DOMString default, optional BooleanCallback complete);
			</pre>

			<code>prompt</code> requires overloading, as the existing interface already has an optional parameter.

	===showModalDialog===		===showModalDialog===

	<code>window.showModalDialog</code> ~~should be deprecated and removed~~ from the platform. Web sites ~~should~~ use e.g. <code>window.open</code> instead.		I would like to propose deprecating and eventually removing <code>window.showModalDialog</code> from the platform. Web sites can already now use e.g. <code>window.open</code> instead. However, I'm not quite sure how this could be achieved.


Line 34:		Line 55:
	==Issues==		==Issues==

	What would a reasonable plan to deprecate <code>showModalDialog</code> look like		What would a reasonable plan to deprecate <code>showModalDialog</code> look like?

	[[Category:Proposals]]		[[Category:Proposals]]

Jochen: Initial proposal for dealing with modal dialogs

2012-02-14T14:17:50Z

Initial proposal for dealing with modal dialogs

New page

==Overview==

This document describes a proposal for gradually removing modal dialogs and prompts from the platform.

==Rationale==

In a tabbed browser, modal dialogs are potentially disrupting the work flow of the user as they can't interact with any other web site as long as the modal dialog is displayed.

Furthermore, implementing <code>showModalDialog</code> might require running a nested message loop which caused several security issues in the past.

==Proposal==

===Callbacks===

For the following modal prompts, a callback parameter is introduced

* <code>alert</code>
* <code>confirm</code>
* <code>prompt</code>

When these functions are invoked with a callback parameter, they return immediately (instead of blocking). The callback is invoked as soon as the modal dialog closes. For <code>confirm</code> and <code>prompt</code>, the callback takes one parameter which is set to the value to modal version would have returned.

===showModalDialog===

<code>window.showModalDialog</code> should be deprecated and removed from the platform. Web sites should use e.g. <code>window.open</code> instead.

==Examples==

<pre>
window.confirm("Are you sure?", function(result) { if (result) doIt(); });
</pre>

==Issues==

What would a reasonable plan to deprecate <code>showModalDialog</code> look like

[[Category:Proposals]]